Optimize service port definition

service/svc.tf

@@ -7,21 +7,10 @@ locals {
     "protocol"   = var.protocols[idx]
     "targetPort" = target
   }] : []
-  ext_ports = var.svc_type == "ExternalName" ? [for idx, target in var.targets : {
-    "name"       = target
-    "port"       = var.ports[idx]
-    "protocol"   = var.protocols[idx]
-    "targetPort" = var.ports[idx]
-  }] : []
-  lb_ports = var.svc_type == "LoadBalancer" ? [for port in var.lb_ports : {
-    "port"       = port.port.number
-    "name"       = port.name
-    "targetPort" = port.port.number
-  }] : []
-  node_ports = var.svc_type == "NodePort" ? [for idx, port in var.ports : {
-    "port"       = port
-    "targetPort" = port
-    "nodePort"   = var.node_ports[idx]
+  node_ports = var.svc_type == "NodePort" ? [for port_map in var.port_mapper : {
+    "port"       = port_map.port
+    "targetPort" = port_map.target
+    "nodePort"   = port_map.port
   }] : []
   metadata = merge(
     {
@@ -40,9 +29,9 @@ locals {
       selector = local.selector
     },
     "ExternalName" = {
-      type           = "ExternalName"
-      externalName   = var.target_host
-      ports          = local.ext_ports
+      type         = "ExternalName"
+      externalName = var.target_host
+      ports        = local.default_ports
     },
     "NodePort" = {
       type     = "NodePort"
@@ -78,6 +67,6 @@ resource "kubectl_manifest" "endpoint" {
     subsets:
       - addresses:
           - ip: ${var.target_host}
-        ports:  ${jsonencode([for port in var.ports : { "port" = port }])}
+        ports:  ${jsonencode([for port_map in var.port_mapper : { "port" = port_map.port }])}
   EOF
 }